Repository navigation
Don't reuse a shared result once the run has moved on - #27
Merged
hyperrealist merged 1 commit intoOct 19, 2026
Merged
Conversation
/binned and /render reuse a result for identical requests for half a second. The poll a UI makes when a scan ends could therefore be given the result of the poll just before, computed without the scan's last points, and nothing polls after it. Results are now also keyed on how far the run has got, as its catalog records it: whether it has a stop document, and the shape of its camera's RedTotal. Concurrent polls of an unchanged run still share one computation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BsMDFhupHcBFbVJPK8QAvR
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 95.49% 95.56% +0.06%
==========================================
Files 5 5
Lines 799 811 +12
==========================================
+ Hits 763 775 +12
Misses 36 36 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/binnedand/renderreuse a result for identical requests for 0.5 s, so the poll a UI makes when a scan ends could get the previous poll's result, without the scan's last points. Shared results are now also keyed on the run's progress in the catalog (stop document present, shape ofprimary/RedTotal), so they are never reused once the run has grown or finished. Concurrent polls of an unchanged run still share one computation.To test:
tests/test_visr.py -k shared_result(fails without the change).🤖 Generated with Claude Code
https://claude.ai/code/session_01BsMDFhupHcBFbVJPK8QAvR