Repository navigation
Create common mirror classes and populate I05s mirrors - #1418
Merged
Merged
Conversation
added 9 commits
July 30, 2025 13:48
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1418 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 318 318
Lines 12139 12205 +66
=======================================
+ Hits 12031 12097 +66
Misses 108 108 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Sorry, this will need to be updated to comply with the new structure of dodal.devices.beamlines.iXX |
oliwenmandiamond
left a comment
Contributor
There was a problem hiding this comment.
This looks good. Thank you for making it comply with the new structure! Just minor formatting change and reuse the defaults and then happy to approve
Contributor
Author
|
I'm going to merge this one, I don't think there are any other comments to address and it seems to be blocked here forever. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1424
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}