Skip to content

Create common mirror classes and populate I05s mirrors - #1418

Merged
Villtord merged 65 commits into
mainfrom
common-mirror
Mar 12, 2026
Merged

Villtord merged 65 commits into
mainfrom
common-mirror

Conversation

@Villtord

@Villtord Villtord commented Jul 31, 2025 •

Copy link
Copy Markdown
Contributor

Fixes #1424

Instructions to reviewer on how to test:

  1. dodal connect i05, i05-1
  2. Confirm no errors in tests

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@codecov

codecov Bot commented Jul 31, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.11%. Comparing base (ec33ee7) to head (347f60e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1418   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         318      318           
  Lines       12139    12205   +66     
=======================================
+ Hits        12031    12097   +66     
  Misses        108      108           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Villtord
Villtord changed the base branch from main to create-i05-shared-beamline-module July 31, 2025 15:27
Base automatically changed from create-i05-shared-beamline-module to main August 1, 2025 12:55
@Villtord Villtord self-assigned this Aug 4, 2025
@Villtord
Villtord requested a review from DominicOram January 30, 2026 10:32
@oliwenmandiamond

Copy link
Copy Markdown
Contributor

Sorry, this will need to be updated to comply with the new structure of dodal.devices.beamlines.iXX

@oliwenmandiamond oliwenmandiamond left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thank you for making it comply with the new structure! Just minor formatting change and reuse the defaults and then happy to approve

Comment thread src/dodal/devices/common_mirror.py Resolved
Comment thread src/dodal/devices/common_mirror.py Resolved
Comment thread src/dodal/devices/common_mirror.py Resolved
@Villtord

Copy link
Copy Markdown
Contributor Author

I'm going to merge this one, I don't think there are any other comments to address and it seems to be blocked here forever.

@Villtord
Villtord merged commit 338505a into main Mar 12, 2026
10 checks passed
@Villtord
Villtord deleted the common-mirror branch March 12, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create some common optics mirrors classes and populate I05 optics with them

5 participants