Repository navigation
Fix system tests - #1503
Merged
Merged
Fix system tests#1503
Conversation
jacob-williamson
added
the
dev experience
DominicOram
approved these changes
Dec 8, 2025
DominicOram
left a comment
DominicOram
left a comment
Contributor
There was a problem hiding this comment.
Thanks, one comment, take it or leave it
Comment on lines
+483
to
+484
| "micronsPerPixelX": 0.806, | ||
| "micronsPerPixelY": 0.806, |
Contributor
There was a problem hiding this comment.
Nit: For future reference I think you can probably use pytest.approx here to avoid similar things in the future
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1503 +/- ##
=======================================
Coverage 92.27% 92.27%
=======================================
Files 142 142
Lines 8075 8075
=======================================
Hits 7451 7451
Misses 624 624
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes system tests. Some were rounding errors due to changing from
pixels_per_microntomicrons_per_pixeleverywhere. The others are issues to do with having a different DCM device in theUndulatorDCMfixture to theLoadCentreCollectCompositefixture, introduced by changes to device manager (see #1459).Instructions to reviewer on how to test:
Checks for reviewer