Repository navigation
fix: give merge_group builds a valid version name in docs.yml - #72
Conversation
merge_group's ref_name is GitHub's internal gh-readonly-queue/<base>/pr-<n>-<sha>, which contains '/' and fails the URL-path-segment check, hard-failing docs.yml for repos using a merge queue. These builds are never gathered by publish.yml's engine, so a fixed "merge-queue" name is enough. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0183zj2nfvaMK3Yo14Wwkych
|
I have no idea if this is fixing anything, This is pure vibe coding |
|
I think I agree. The merge queue docs build is still valuable to check it builds, but the artifact can then be thrown away. claude reviewing claude: On #72 itself The shape is right. The validator's failure mode is deliberate (fail loud rather than silently mangle a ref into a colliding path segment), so special-casing merge_group to a fixed literal is more in keeping than loosening the character check. The error message's own advice — "exclude it from the workflow's triggers" — is actively wrong for merge queues, so it's worth handling centrally: every consumer that turns on a merge queue hits this hard failure. Two things I'd raise on the PR:
|
docs.yml now skips uploading a merge_group build's docs artifact — it's never gathered (the version name is the fixed "merge-queue" literal), so uploading it was pure storage churn. publish.yml's guard gains a third term, event != 'merge_group', since the other two guards both still pass for a merge-queue run and would otherwise fire a full, no-op site reassemble-and-redeploy on every queue entry. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BzmGP9Z1oWtHKVLbS8YD8C
…update code-review caught two leftover mentions of "two guards" after the previous commit added a third (event != 'merge_group'). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BzmGP9Z1oWtHKVLbS8YD8C
Code review flagged that this step-level if: had no coverage anywhere in the harness — test_shape.py only asserted publish.yml's job-level guard, so a future refactor could silently drop or invert it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011i7JVVjbNJ9ptXJaetbFH5
|
After checking in blueapi this did work. 🎉 |
merge_group's ref_name is GitHub's internal
gh-readonly-queue//pr--, which contains '/' and fails the URL-path-segment check, hard-failing docs.yml for repos using a merge queue. These builds are never gathered by publish.yml's engine, so a fixed "merge-queue" name is enough.
The issue it is trying to fix in blueapi which uses merge queues
Claude-Session: https://claude.ai/code/session_0183zj2nfvaMK3Yo14Wwkych