Repository navigation
fix: Migrate to tox-uv-bare - #403
Open
AlexanderWells-diamond wants to merge 4 commits into
Open
AlexanderWells-diamond wants to merge 4 commits into
AlexanderWells-diamond wants to merge 4 commits into
Conversation
AlexanderWells-diamond
force-pushed
the
migrate_to_tox_uv_bare
branch
from
November 11, 2026 14:34
dd008c7 to
0864667
Compare
AlexanderWells-diamond
changed the title
Contributor
Author
|
I'm having difficulties disentangling test failures that appear to be present on main from changes made on this branch. I'll spend some more time investigating. |
Contributor
Author
Contributor
|
@AlexanderWells-diamond the error Is because of the release migration we're doing in #373 I'll move the tag to a branch which should fix it... |
Contributor
Done. Now it's just the error from #404 |
AlexanderWells-diamond
force-pushed
the
migrate_to_tox_uv_bare
branch
3 times, most recently
from
November 13, 2026 12:22
63ac0b9 to
e5e4a0a
Compare
This removes the need to have `uv` itself packaged into the venv. We now use the devcontainer's default uv version. The devcontainer.json changes are to deal with a migration issue that can occur due to older uv versions being in the venv - if that old version no longer meets the required version in `pyproject.toml` -> `tool.uv` -> `required-version` it means you end up with a venv that cannot run any uv commands as it is below the minimum version.
AlexanderWells-diamond
force-pushed
the
migrate_to_tox_uv_bare
branch
from
November 13, 2026 12:59
e5e4a0a to
77053fd
Compare
tox-uv-bare no longer prepends the directory of the uv binary to PATH, which used to be <project>/.venv/bin when uv was installed as a package. The nested tox runs therefore picked up pytest, pyright and sphinx-build from the outer venv (or not at all). Activate the venv explicitly. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uybqz7UjVJfezyDTBqiHGM
Contributor
Author
|
I think this is now ready to review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the need to have
uvitself packaged into the venv. We now use the devcontainer's default uv version.The devcontainer.json changes are to deal with a migration issue that can occur due to older uv versions being in the venv - if that old version no longer meets the required version in
pyproject.toml->tool.uv->required-versionit means you end up with a venv that cannot run any uv commands as it is below the minimum version.