Open
Conversation
thomascobb
suggested changes
Sep 16, 2019
thomascobb
left a comment
thomascobb
left a comment
There was a problem hiding this comment.
I'd quite like to see a test with some hardcoded numbers in. It would be an easier way in to see what this thing is doing when you see a set of input numbers and a set of output numbers.
| UAxes = Union[AAxes, Sequence[str], str] | ||
| with Anno("Centre of rotation"): | ||
| ACoR = Array[float] | ||
| UCoR = Union[ACoR, list] |
There was a problem hiding this comment.
Suggested change
| UCoR = Union[ACoR, list] | |
| UCoR = Union[ACoR, Sequence[float]] |
| # type: (UAxes, ARotationAngle, UCoR) -> None | ||
| self.angle = ARotationAngle(angle) | ||
| self.axes = AAxes(axes) | ||
| self.centreOfRotation = ACoR(centreOfRotation) |
There was a problem hiding this comment.
Need to check that this is 2D as well
| i_up = pos[i] | ||
| j_low = pos[j] | ||
| j_up = pos[j] | ||
| if j in point.lower: |
|
|
||
| float_error_tolerance = 1e-12 | ||
|
|
||
| class RandomOffsetMutatorTest(ScanPointGeneratorTest): |
There was a problem hiding this comment.
Suggested change
| class RandomOffsetMutatorTest(ScanPointGeneratorTest): | |
| class RotationMutatorTest(ScanPointGeneratorTest): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added rotation mutator, which takes a pair of axes which define a plane, a centre of rotation and a rotation amount and rotates the generated points about the specified point by the specified angle in this plane.