Repository navigation
Add to i05_shared.py s1_xgap and s1_ygap #441
Description
The s1 device are slits
<bean id="s1_xcentre_motor" class="gda.device.motor.EpicsMotor">
<property name="pvName" value="BL05I-AL-SLITS-01:XCENTRE" />
</bean>
<bean id="s1_xgap_motor" class="gda.device.motor.EpicsMotor">
<property name="pvName" value="BL05I-AL-SLITS-01:XSIZE" />
</bean>
<bean id="s1_ycentre_motor" class="gda.device.motor.EpicsMotor">
<property name="pvName" value="BL05I-AL-SLITS-01:YCENTRE" />
</bean>
<bean id="s1_ygap_motor" class="gda.device.motor.EpicsMotor">
<property name="pvName" value="BL05I-AL-SLITS-01:YSIZE" />
</bean>
<bean id="s1_xring_motor" class="gda.device.motor.EpicsMotor">
<property name="pvName" value="BL05I-AL-SLITS-01:XRING" />
</bean>
<bean id="s1_xhall_motor" class="gda.device.motor.EpicsMotor">
<property name="pvName" value="BL05I-AL-SLITS-01:XHALL" />
</bean>
<bean id="s1_ytop_motor" class="gda.device.motor.EpicsMotor">
<property name="pvName" value="BL05I-AL-SLITS-01:YPLUS" />
</bean>
<bean id="s1_ybottom_motor" class="gda.device.motor.EpicsMotor">
<property name="pvName" value="BL05I-AL-SLITS-01:YMINUS" />
</bean>In dodal, we already have slit devices https://github.com/DiamondLightSource/dodal/blob/main/src/dodal/devices/slits.py. We can use class Slits as a base and then extend to add xring and xhall attributes. This should be added to i05_shared.py
I've had a look in GDA and can see other beamlines also use xring and xhall. E.g B07. So the class should also live in dodal/devices/slits.py so other beamlines can reuse. E.g SlitsXRingXHall
Metadata
Metadata
Assignees
Labels
No labels
Activity
[-]`s1_xgap` and `s1_ygap`[/-][+]Add i05 `s1_xgap` and `s1_ygap`[/+][-]Add i05 `s1_xgap` and `s1_ygap`[/-][+]Add to i05_shared.py `s1_xgap` and `s1_ygap`[/+]DG-At-Diamond commentedon Nov 10, 2026
I believe we can use the existing SlitsWithIndividualBlades as xring and xhall are just x_minus and x_plus (minus in the x direction is towards the ring, plus is towards the hall).
oliwenmandiamond commentedon Nov 10, 2026
Note, we spoke to controls and they believe we can reuse existing classes as they are the same thing, just different name. We are using existing class for time being and show to beamline. We then either get controls to align or update our classes to use the names beamline want.