Repository navigation
407 add automatic data analysis com gaussian fit 1st2nd derivatives after scans complete - #440
Open
Relm-Arrowny wants to merge 35 commits into
Conversation
Open
14 of 15 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #440 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 40 41 +1
Lines 1916 2057 +141
==========================================
+ Hits 1916 2057 +141 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…-fit-1st2nd-derivatives-after-scans-complete
Relm-Arrowny
marked this pull request as ready for review
November 2, 2026 11:13
This was referenced Nov 2, 2026
DanPorter
reviewed
Nov 2, 2026
DanPorter
left a comment
Collaborator
There was a problem hiding this comment.
This looks like a great addition and provides the useful requested fitting capability.
I haven't tested this yet so will do so before approving, but I've also left some comments and queries that should be addressed.
… fit rather than raising exception
…-fit-1st2nd-derivatives-after-scans-complete
oliwenmandiamond
approved these changes
Nov 3, 2026
…-fit-1st2nd-derivatives-after-scans-complete
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #407
Changes
sm_bluesky.common.math:fit_gaussian(Gaussian + linear background vialmfit)calculate_com(centre of mass with optional baseline subtraction)calculate_derivatives(1st/2nd derivatives, min/max slopes, and zero crossings)src/sm_bluesky/common/clients/blueapi_session.py:auto_analyse=True) and added fitting result in to cached data.fit_scan(),set_fit_axes(), andlast_fit(centre,com,max_slope_x,min_slope_x, 'zero_crossings`) in the interactive IPython shell for scripting.InteractivePlotWindowfor 1D and 2D plot modes.BlueAPISessiontutorial documentation.Instructions to reviewer on how to test:
Checks for reviewer