fix: guard final writeHookOutput against stdout EPIPE in ponytail-activate (#149)#152
Merged
DietrichGebert merged 1 commit intoJun 18, 2026
Conversation
…ivate (DietrichGebert#149) The final writeHookOutput('SessionStart', ...) call was the only operation in the file outside a try/catch. writeHookOutput ends in a bare process.stdout.write, so a closed stdout / broken pipe (EPIPE) at hook exit throws uncaught and crashes the hook with a non-zero exit code. Wrap it to match the file's existing never-block-session-start posture.
22f5708 to
2bc8947
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #149. The final
writeHookOutput('SessionStart', mode, output)call at ponytail-activate.js:72 was the only operation in the file left outside a try/catch —setModeand the statusline detection are both guarded.writeHookOutputends in a bareprocess.stdout.write(...)(ponytail-runtime.js:42) with no internal guard, so if stdout is closed or the pipe to the host breaks at hook exit,process.stdout.writethrowsEPIPE, which becomes an uncaught exception and crashes the hook with a non-zero exit code.Fix
Wrap the final write in try/catch, matching the never-block-session-start posture used everywhere else in the file:
node --checkpasses.Credit
Thanks to @Indrajeet-Badhel for triaging this issue and confirming the approach — this PR implements the same guard discussed there.