Skip to content

Ensure public assets directory exists and Fix routing for non ascii letter #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hayzamjs merged 1 commit into from
Aug 5, 2025
Merged

Ensure public assets directory exists and Fix routing for non ascii letter #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions utils/docs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ func CopyPublicAssetsToDocsIfEmpty(docPath string) error {
}

if isEmptyDir {
// make sure destination exists
if err := MakeDir(publicAssetsDirPath); err != nil {
logger.Error("could not create dest dir: " + publicAssetsDirPath)
return err
}
err = os.CopyFS(innerDocPublicPath, os.DirFS(publicAssetsDirPath))
if err != nil {
return err
Expand Down
13 changes: 11 additions & 2 deletions utils/strings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ func RemoveSpaces(input string) string {

func StringToUint(input string) (uint, error) {
output, err := strconv.ParseUint(input, 10, 32)

if err != nil {
return 0, err
}
Expand All @@ -62,7 +61,17 @@ func StringToFileString(input string) string {
if input == "" {
return "unnamed-file"
}
return url.PathEscape(input)
return url.PathEscape(RemoveNonASCII(input))
}

func RemoveNonASCII(input string) string {
var result []rune
for _, r := range input {
if r <= 127 {
result = append(result, r)
}
}
return string(result)
}

func UintPtr(v uint) *uint {
Expand Down
Loading