Security Fixes: User Enumeration Mitigation and Removal of Password Hash Exposure#34
Open
Noxurge wants to merge 2 commits intoDifuseHQ:masterfrom
Open
Security Fixes: User Enumeration Mitigation and Removal of Password Hash Exposure#34Noxurge wants to merge 2 commits intoDifuseHQ:masterfrom
Noxurge wants to merge 2 commits intoDifuseHQ:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces two security fixes related to authentication behavior and exposure of sensitive data in user-related API responses.
1 - User Enumeration Mitigation
The authentication endpoint returned different error messages depending on whether the username existed or not.
This allowed attackers to determine valid usernames by comparing responses.
Fix implemented
Unified authentication error responses.
All invalid login attempts now return the same generic message.
2 - Removal of Password Hash Exposure
The user detail API was including password hashes in the returned data, which is unnecessary and unsafe.
Fix implemented
Sensitive fields were removed from all user-related API serializers.
Ensured password hashes are not returned under any condition.