Skip to content

Harden CI quality gates and enforce stricter static checks#11

Merged
DigitalHerencia merged 3 commits into
mainfrom
codex/remove-ignoreduringbuilds-and-ignorebuilderrors
Feb 15, 2026
Merged

Harden CI quality gates and enforce stricter static checks#11
DigitalHerencia merged 3 commits into
mainfrom
codex/remove-ignoreduringbuilds-and-ignorebuilderrors

Conversation

@DigitalHerencia

Copy link
Copy Markdown
Owner

Motivation

  • Prevent builds from silently skipping lint/type errors by removing the Next.js build bypass flags so quality checks fail fast.
  • Add CI gates that run linting, typechecking and unit tests on PRs and pushes so regressions are blocked before merge.
  • Raise static-analysis standards to catch unsafe any, unhandled promises, and server/client boundary mistakes early.

Description

  • Removed eslint.ignoreDuringBuilds and typescript.ignoreBuildErrors from next.config.mjs so build-time errors are surfaced.
  • Added a GitHub Actions workflow .github/workflows/ci.yml with separate lint, typecheck, and test jobs that run on pull requests and pushes to main.
  • Replaced legacy .eslintrc.json with a flat eslint.config.mjs enabling stricter TypeScript rules (@typescript-eslint/no-explicit-any, @typescript-eslint/no-floating-promises, @next/next/no-async-client-component) while adding targeted exemptions for a small set of legacy files to keep the rollout incremental.
  • Tightened tsconfig.json by enabling noImplicitAny and applied a number of small, safe code edits (voiding fire-and-forget async calls in useEffect, narrowing a few formatter/callback types, and clarifying salespeople typings) to reduce immediate lint noise.
  • Added developer tooling and CI support: updated package.json scripts (lint, typecheck, test), added vitest and vitest.config.ts, a baseline unit test tests/utils.test.ts, and an ESLint/TypeScript dev dependency bump in the lockfile.

Testing

  • Ran pnpm lint locally and the workspace linter completed successfully (final run: ✅).
  • Ran pnpm test and the new Vitest suite passed (2 tests, ✅).
  • Ran pnpm typecheck and it failed due to broad pre-existing repository type issues not introduced by this change (reported as ❌); CI will surface these failures so they can be triaged and fixed incrementally.

Codex Task

@vercel

vercel Bot commented Feb 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hustlers-code Error Error Feb 15, 2026 0:06am

@DigitalHerencia
DigitalHerencia merged commit ebbf62b into main Feb 15, 2026
1 of 5 checks passed
@DigitalHerencia
DigitalHerencia deleted the codex/remove-ignoreduringbuilds-and-ignorebuilderrors branch February 15, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant