Fix for #6 (Capture regex for new injection method is too strict)#7
Open
ehoogeveen-medweb wants to merge 1 commit intoDigitalbrainstem:masterfrom
Open
Fix for #6 (Capture regex for new injection method is too strict)#7ehoogeveen-medweb wants to merge 1 commit intoDigitalbrainstem:masterfrom
ehoogeveen-medweb wants to merge 1 commit intoDigitalbrainstem:masterfrom
Conversation
…erpolations and add vue-tag2 to match templates wrapped in function calls. This also removes keywords-functions and keywords-object as they were breaking syntax highlighting in some places and didn't seem to serve any function.
Member
|
I will test this out. If all checks out. I will merge it. Thanks! |
Author
|
Any news on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the syntax highlighting issues I was seeing and also adds support for templates wrapped in a function. To match the function call I take advantage of unicode property escapes (similar to using
[A-Za-z0-9]but matching various non-ASCII letters and digits as well).In addition, I modified the original regex a little to better match the original TM scopes, and added a pattern to restore syntax highlighting for template string interpolations.
Sorry if this is a bit much to pull in one go, I'm still not really used to using Github. Let me know if there's anything I can do to make the process easier.