-
Notifications
You must be signed in to change notification settings - Fork 0
feat(rules): the custom_css rule target — SiteAgent 2.20.0 (Aura#576, Plan A) #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
7f1a37b
feat(rules): custom_css target — block/warn over-block, allow needs p…
BenKalsky 202fbbd
fix(rules): allow custom_css fails closed at the set level, not per-t…
BenKalsky 3b727f6
feat(rules): an elementor-mcp below 1.37.0 counts its page writes as …
BenKalsky 46a4f4d
feat(door): Elementor's own door declares custom_css — precise from n…
BenKalsky 1a574b6
test(door): every write is classified for CSS; NO_CSS is checked agai…
BenKalsky 0960807
feat(status): css_rules.fork — precise, widened or absent (Aura#576)
BenKalsky f687dd0
fix(rules): precise needs Elementor_MCP_Rules::css_touches(), not jus…
BenKalsky 2d0b860
fix(door): non-array settings, odd CSS values and unread schema shape…
BenKalsky 92c07cb
test(rules): widening never speaks for allow, proven at match(); seam…
BenKalsky 786d4fe
fix(rules): a custom_css id is exact only if every touch on it is (Co…
BenKalsky ddad64a
fix(door): an unresolved schema shape is never absorbed by a handled …
BenKalsky 45a552c
fix(door): a CSS-named key in an open settings container is CSS of un…
BenKalsky c2483fe
test(rules): reflection on PHP 7.4 needs setAccessible (CI on #135)
BenKalsky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This release identifies the new behavior as 2.20.0, but the plugin header,
AURA_WORKER_VERSION, andreadme.txtstable tag all remain at 2.19.3. Consequently, an existing 2.19.3 installation cannot receive this build through the normal Aura self-update path:class-aura-worker-updater.phpexplicitly rejects a package whose version equals the installed version before installing it. Update all three version declarations so this release can actually be deployed and reported as 2.20.0.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declined for this PR, by procedure: the version bump to 2.20.0 (plugin header,
AURA_WORKER_VERSION, readme stable tag, changelog) ships in the separate release PR opened after this feature PR merges — as stated in the PR body. Nothing is deployed from this branch.