Repository navigation
feat: install ledger — every plugin/theme install with its door and source (P6.3 phase 2, SiteAgent 2.22.0) #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e6aa829
feat(ledger): the install ledger's store — 200 entries or 90 days, si…
BenKalsky ce88778
fix(ledger): Task 1 review — rows older than the count edge are rotat…
BenKalsky 8408168
feat(ledger): observe plugin and theme installs — token-correlated fr…
BenKalsky f9a9f19
fix(ledger): Task 2 review — a rejected entry moves coverage to a bou…
BenKalsky 8225bc1
feat(ledger): SiteAgent's own installs record transport siteagent (P6…
BenKalsky a792962
feat(audit): audit_agent_code reports the install ledger as installs …
BenKalsky fd02389
fix(ledger): final review — reactivation restarts coverage; per-site …
BenKalsky 143de75
fix(ledger): Codex r1 on #139 — restart the network ledger once per a…
BenKalsky 8dc8e01
fix(ledger): Codex r2 on #139 — restart coverage before activation in…
BenKalsky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although the restart was moved outside the per-site loop, it still runs after that loop. On a fresh activation,
aura_worker_activate_site()callsaura_worker_maybe_upgrade(), which callsensure_started()and creates the state and empty ring; this subsequentrestart_coverage()therefore treats the fresh ledger as existing and immediately setsevicted: true. This affects both single-site and network-wide fresh activations, falsely reporting that coverage was lost before anything could have been observed.Useful? React with 👍 / 👎.