Repository navigation
fix(ci): check vaultx --version against the cached binary - #2
Merged
Merged
Conversation
The launcher's first run downloads the binary and prints an "installed at" line to stdout, so an exact match on that run fails even though the install is good. Run once to fetch and verify, assert the cached binary exists, then assert the exact version output. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the last two checks in
publish-github-packages, which failed in run 42502411379. The publish itself succeeded (+ @dijo-404/vaultx-cli@1.0.0), and the readback diff passed.The first
vaultx --versionrun downloads the binary and printsvaultx 1.0.0 installed at …to stdout (npm/bin/install.js:202). The captured output was therefore two lines, and the exact-match check failed. That also skipped the repository-association check.The step now:
vaultx 1.0.0exactly on a second run, which uses the cached binary.Re-running after merge takes the "already published, verify only" path and doesn't publish again.
🤖 Generated with Claude Code