Skip to content

fix(ci): check vaultx --version against the cached binary - #2

Merged
Dijo-404 merged 1 commit into
mainfrom
ci/github-packages-verify
Nov 8, 2026
Merged

Dijo-404 merged 1 commit into
mainfrom
ci/github-packages-verify

Conversation

@Dijo-404

@Dijo-404 Dijo-404 commented Nov 8, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes the last two checks in publish-github-packages, which failed in run 42502411379. The publish itself succeeded (+ @dijo-404/vaultx-cli@1.0.0), and the readback diff passed.

The first vaultx --version run downloads the binary and prints vaultx 1.0.0 installed at … to stdout (npm/bin/install.js:202). The captured output was therefore two lines, and the exact-match check failed. That also skipped the repository-association check.

The step now:

  1. runs once to fetch and verify the binary;
  2. checks that the cached binary exists;
  3. matches vaultx 1.0.0 exactly on a second run, which uses the cached binary.

Re-running after merge takes the "already published, verify only" path and doesn't publish again.

🤖 Generated with Claude Code

The launcher's first run downloads the binary and prints an
"installed at" line to stdout, so an exact match on that run fails even
though the install is good. Run once to fetch and verify, assert the
cached binary exists, then assert the exact version output.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 8, 2026 16:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@Dijo-404
Dijo-404 merged commit 762b89e into main Nov 8, 2026
4 of 5 checks passed
@Dijo-404
Dijo-404 deleted the ci/github-packages-verify branch November 8, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants