Skip CUDA-only libhipcxx atomic_codegen when CUDAToolkit is absent - #3
Open
Dillflix wants to merge 2 commits into
Open
Skip CUDA-only libhipcxx atomic_codegen when CUDAToolkit is absent#3Dillflix wants to merge 2 commits into
Dillflix wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
math-libs/libhipcxx/test/atomic_codegenunconditionally requires CUDA tools likecuobjdumpeven whenCUDAToolkit/nvccare not present.Description
strix-halo/vllm-packages.yamlto insert an early-return guard intomath-libs/libhipcxx/test/atomic_codegen/CMakeLists.txtwhenCUDAToolkit_FOUNDis false so the CUDA-only test setup is skipped.strix-halo/BUILD-FIXES.mdwith symptom, root cause, and fix rationale.Testing
git diff --checkto ensure no whitespace or obvious diff problems and it passed.strix-halo/vllm-packages.yamlandstrix-halo/BUILD-FIXES.mdwith line-numbered output to verify the exact inserted patch and documentation.yq, butyqwas not installed in this environment (informational only); the textual inspections above confirmed the changes.Codex Task