Skip to content

Skip CUDA-only libhipcxx atomic_codegen when CUDAToolkit is absent - #3

Open
Dillflix wants to merge 2 commits into
mainfrom
codex/fix-libhipcxx-configuration-errors
Open

Skip CUDA-only libhipcxx atomic_codegen when CUDAToolkit is absent#3
Dillflix wants to merge 2 commits into
mainfrom
codex/fix-libhipcxx-configuration-errors

Conversation

@Dillflix

Copy link
Copy Markdown
Owner

Motivation

  • The TheRock configure step aborts on AMD-only systems because math-libs/libhipcxx/test/atomic_codegen unconditionally requires CUDA tools like cuobjdump even when CUDAToolkit/nvcc are not present.
  • This is an NVIDIA-only test that should not block ROCm-only builds.

Description

  • Added a YAML-driven patch in strix-halo/vllm-packages.yaml to insert an early-return guard into math-libs/libhipcxx/test/atomic_codegen/CMakeLists.txt when CUDAToolkit_FOUND is false so the CUDA-only test setup is skipped.
  • Documented the issue and the workaround in strix-halo/BUILD-FIXES.md with symptom, root cause, and fix rationale.
  • No other build logic was changed; the patch is applied via the existing manifest-driven patching mechanism.

Testing

  • Ran git diff --check to ensure no whitespace or obvious diff problems and it passed.
  • Inspected the updated strix-halo/vllm-packages.yaml and strix-halo/BUILD-FIXES.md with line-numbered output to verify the exact inserted patch and documentation.
  • Attempted to validate the YAML patch entry with yq, but yq was not installed in this environment (informational only); the textual inspections above confirmed the changes.

Codex Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant