fix: review follow-ups for #51–#62 — one rule per place, and the spec matches the code - #64

Merged

DimazzzZ merged 26 commits into

mainfrom

fix/review-51-62-findings

Sep 24, 2026

Commits on Sep 24, 2026

fix(explorer): a seeded mainnet URL is not a choice the user made
DimazzzZ
committed
94b5836
fix(sync): an unreadable profile network is unknown, not mainnet
DimazzzZ
committed
dd90548
fix(names): a failed lookup is not the same as nothing to reveal
DimazzzZ
committed
ff0f1a7
fix(names): the rest of the context builder says when a lookup failed
DimazzzZ
committed
db2aa8d
fix(node): finish routing node config through the profile (ADR-001, Step 2)
DimazzzZ
committed
147aef7
fix(bridge): the TS mirror stops making required fields optional
DimazzzZ
committed
9dd98b8
test: one lock per piece of global state, and stop excluding testable code
DimazzzZ
committed
14c4ba4
refactor: delete the parts nothing calls
DimazzzZ
committed
4af5e58
docs: make the comments say what the code beside them does
DimazzzZ
committed
dcb766d
docs: stop the manual promising what the wallet does not do
DimazzzZ
committed
5ecea83
docs(specs): write down the behaviour that shipped without a spec
DimazzzZ
committed
1bfbd04
refactor: one home per shared thing
DimazzzZ
committed
145d10e
refactor: complete fixtures, and one copy of what was written three times
DimazzzZ
committed
c33c393
refactor: one spelling per rule, and a guard where two are needed
DimazzzZ
committed
91c8e94
fix(node): the directory a node writes into is not a thing to guess
DimazzzZ
committed
bdd74e1
refactor: thirteen positional arguments, six of them bool
DimazzzZ
committed
0456db7
fix(read): an unreadable network picks no explorer, not mainnet's
DimazzzZ
committed
c7f7818
test(node): pin what "hsd failed to start" actually matches
DimazzzZ
committed
4798d9a
docs(specs): record the node behaviour #56 shipped without one
DimazzzZ
committed
c60447e
refactor(names): name the shapes, share the sentence
DimazzzZ
committed
55fd143
refactor(ui): a function that can answer should answer
DimazzzZ
committed
5855044
fix(sync): a network this step cannot read is not a node to trust
DimazzzZ
committed
7c66925
fix(rust): a DB failure in a user command is an error, and one owner gate
DimazzzZ
committed
5fe7823
test: pin the foreign-chain sync refusal and the live-tip preference
DimazzzZ
committed
4e04db8
fix(ui): one explorer rule, one batch runner, and the amount the batch signs
DimazzzZ
committed
7cb3f8b
docs: say what the code does, and point where it lives
DimazzzZ
committed
227a372

Navigation Menu

fix: review follow-ups for #51–#62 — one rule per place, and the spec matches the code - #64

fix: review follow-ups for #51–#62 — one rule per place, and the spec matches the code#64
DimazzzZ merged 26 commits into
mainfrom
fix/review-51-62-findings

Commits on Sep 24, 2026

fix(explorer): a seeded mainnet URL is not a choice the user made

fix(sync): an unreadable profile network is unknown, not mainnet

fix(names): a failed lookup is not the same as nothing to reveal

fix(names): the rest of the context builder says when a lookup failed

fix(node): finish routing node config through the profile (ADR-001, Step 2)

fix(bridge): the TS mirror stops making required fields optional

test: one lock per piece of global state, and stop excluding testable code

refactor: delete the parts nothing calls

docs: make the comments say what the code beside them does

docs: stop the manual promising what the wallet does not do

docs(specs): write down the behaviour that shipped without a spec

refactor: one home per shared thing

refactor: complete fixtures, and one copy of what was written three times

refactor: one spelling per rule, and a guard where two are needed

fix(node): the directory a node writes into is not a thing to guess

refactor: thirteen positional arguments, six of them bool

fix(read): an unreadable network picks no explorer, not mainnet's

test(node): pin what "hsd failed to start" actually matches

docs(specs): record the node behaviour #56 shipped without one

refactor(names): name the shapes, share the sentence

refactor(ui): a function that can answer should answer

fix(sync): a network this step cannot read is not a node to trust

fix(rust): a DB failure in a user command is an error, and one owner gate

test: pin the foreign-chain sync refusal and the live-tip preference

fix(ui): one explorer rule, one batch runner, and the amount the batch signs

docs: say what the code does, and point where it lives