Fix/use fake player for all BE's when calling getCloneItemStack()#505
Open
SubordinalBlue wants to merge 4 commits into
Open
Fix/use fake player for all BE's when calling getCloneItemStack()#505SubordinalBlue wants to merge 4 commits into
SubordinalBlue wants to merge 4 commits into
Conversation
Author
|
p.s. did test fix in test world |
SubordinalBlue
changed the title
Author
|
Things seem fine in test world; though only the energy transmitter one was known to me to crash before, when interacting with Ender IO somehow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To start, it's just fixing the EnergyTransmitter so it does not crash when Ender IO energy conduits are in range.
Plan is to apply same change (passing usefulFakePlayer) to all calls to getCloneItemStack() in all BE's.
Cheers.