initial commit - #1
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces an initial implementation of a Maestro plugin for the 3decision structure database. The plugin enables users to search for structures, browse projects, load structures with transformation matrices, and access associated files directly from within Maestro.
Changes:
- New plugin infrastructure with entry point and package structure
- API client for 3decision REST API with authentication, search, and export capabilities
- Full-featured GUI with tabbed interface for Search, Projects, and Associated Files
- Support for loading PDB structures with transformation matrices and importing various file formats
Reviewed changes
Copilot reviewed 4 out of 13 changed files in this pull request and generated 35 comments.
Show a summary per file
| File | Description |
|---|---|
| threedecision_maestro.py | Plugin entry point that handles module loading and error reporting |
| threedecision_maestro_dir/init.py | Package initialization with version info and run_plugin function |
| threedecision_maestro_dir/api_client.py | Comprehensive API client handling authentication, search, structure export, and file downloads |
| threedecision_maestro_dir/gui.py | Main GUI implementation with search, projects, and files tabs plus dark theme styling |
| threedecision_maestro_dir/images/* | UI assets including cog icons and logo files |
| README.md | User documentation with installation, configuration, and usage instructions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@pschmidtke I've opened a new pull request, #2, to work on those changes. Once the pull request is ready, I'll request review from you. |
[WIP] Fix issues based on review comments from initial commit
Security improvements: - Add sanitize_filename() to prevent path traversal attacks - Add sanitize_surface_name() for safe Maestro command injection - Replace bare except clauses with specific exception types - Set config file permissions to 0600 New features: - Add SSL certificate verification toggle in Settings dialog - Extract color constants for maintainable theming - Create create_dark_palette() helper to eliminate duplicate code Code quality: - Move identity_matrix outside loop for efficiency - Update test_connection to make real HTTP request - Convert DARK_STYLESHEET to f-string using color constants - Update all inline styles to use color constants Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Changes addressing Copilot review commentsSecurity improvements
New features
Code quality improvements
Files modified
|
Revert to simpler approach: trust the token if we have one. The _request_with_retry method already handles re-authentication when tokens expire during actual API calls. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Fix pushed: The |
Porting the GUI for 3decision structure, project and associated files loading to maestro.