error: assignment to ‘char *’ from incompatible pointer type ‘char **

[yaideltg]

Describe the bug
Just cloned the repo and typed 'make'. I got the following error.

gcc -W -Wextra -Wwrite-strings -Wstrict-prototypes -DM_OS_LINUX -DMNO_MEM_DEBUG -O2 -g -pg -std=gnu99 -Iplugins/include -Iplugins/LINUXAMD64/molfile -c src/fparams.c -o obj/fparams.o
src/fparams.c: In function ‘get_fpocket_args’:
src/fparams.c:296:24: error: passing argument 1 of ‘strcpy’ from incompatible pointer type [-Wincompatible-pointer-types]
296 | strcpy(&residue_string, pt);
| ^~~~~~~~~~~~~~~
| |
| char * ()[8000]
In file included from src/../headers/fparams.h:19,
from src/fparams.c:2:
/usr/include/string.h:141:39: note: expected ‘char * restrict’ but argument is of type ‘char * ()[8000]’
141 | extern char *strcpy (char *__restrict __dest, const char *__restrict __src)
| ~~~~~~~~~~~~~~~~~^~~~~~
src/fparams.c:297:23: error: assignment to ‘char *’ from incompatible pointer type ‘char **’ [-Wincompatible-pointer-types]
297 | rest2 = residue_string;

To Reproduce
Steps to reproduce the behavior:

1. Clone the repo
2. Hit 'make' in the console.
3. Wait till the error appears

Expected behavior
It's expected for the make to complete successfully.

Desktop (please complete the following information):

• OS: Fedora Linux 41 (Workstation Edition)

Additional context

I have included in line 284 the following declaration for residue_string, and it worked, at least for the compilation. I'm not sure which effect this can have for the results and expected behaviour of the code.

281 strcpy(par->custom_pocket_arg, optarg);
282 char *rest = par->custom_pocket_arg;
283 char *rest2;
284+ char residue_string[8000];
...
296- strcpy(&residue_string, pt);
296+ strcpy(residue_string, pt);

[NF-AMU]

I confirm the issue reported above (Ubuntu 24.10, gcc 14.2.0)

[tcaceresm]

I have the same error, any solution?

[Gnomlos]

Hey I just downloaded and had exactly the same error. I am also on Fedora. Do you have any kind of solution ?

[yaideltg]

Hi, the solution I found is explained at the end of the issue description. I changed the definition of variable residue_string in the problematic file of the source code, and then compiled it.