Skip to content

Fix heap-buffer-overflows in mdpocket/fpocket arg parsing + energy output #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ferreira68 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix heap-buffer-overflows in mdpocket/fpocket arg parsing + energy output #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/energy.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,12 @@ void calculate_pocket_energy_grids(c_lst_pockets *pockets, s_fparams *params, s_



sprintf(final_path, "%s/pockets/pocket_%d_vdw.dx", out_path, pocket_number);
snprintf(final_path, sizeof(final_path), "%s/pockets/pocket_%d_vdw.dx", out_path, pocket_number);
f_vdw = fopen(final_path, "w");
write_grid(pocket_vdw_grid, f_vdw);
fclose(f_vdw);

sprintf(final_path, "%s/pockets/pocket_%d_elec.dx", out_path, pocket_number);
snprintf(final_path, sizeof(final_path), "%s/pockets/pocket_%d_elec.dx", out_path, pocket_number);
f_elec = fopen(final_path, "w");
write_grid(pocket_elec_grid, f_elec);
fclose(f_elec);
Expand Down
4 changes: 2 additions & 2 deletions src/fparams.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ s_fparams *get_fpocket_args(int nargs, char **args)
opterr = 0;
char *pt;
char *apt;
char *residue_string[M_MAX_CUSTOM_POCKET_LEN];
char residue_string[M_MAX_CUSTOM_POCKET_LEN];
short custom_ligand_i = 0;
const char *separators = ",:";
static struct option fplong_options[] = {/*long options args located in fparams.h*/
Expand Down Expand Up @@ -293,7 +293,7 @@ s_fparams *get_fpocket_args(int nargs, char **args)
rest = par->custom_pocket_arg;
while ((pt = strtok_r(rest, ".", &rest)))
{
strcpy(&residue_string, pt);
strcpy(residue_string, pt);
rest2 = residue_string;
apti = 0;
while ((apt = strtok_r(rest2, ":", &rest2)))
Expand Down
2 changes: 1 addition & 1 deletion src/mdparams.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ s_mdparams* get_mdpocket_args(int nargs, char **args) {
char *str_list_file = NULL;
char **args_copy = my_malloc(sizeof (char**) *nargs);
for (i = 0; i < nargs; i++) {
args_copy[i] = my_malloc(sizeof (args[i]));
args_copy[i] = my_malloc(strlen(args[i]) + 1);
strcpy(args_copy[i], args[i]);
}

Expand Down