Repository navigation
docs(mode-switching): macOS lens row; smooth 2D/3D transitions are app-side on every arm - #331
Merged
Merged
Conversation
…p-side on every arm The per-platform table had no macOS row since drv_leia_macos landed (#324): it uses srLensEnable/srLensDisable under the Linux lens-ownership rules (leia_lens_owner_linux.h). Also records that no arm eases a mode switch (no weaver fade, lens-settle hold or cross-fade): the smooth Windows transition is the app's dxr::ModeSwitch (displayxr-common), so a harsh switch is diagnosed in the app, not here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc-only.
docs/display-mode-switching.md. Sincedrv_leia_macos(feat(macos): Leia SR Metal display-processor arm (drv_leia_macos) #324),request_display_modecallssrLensEnable/srLensDisableunder the Linux lens-ownership rules (leia_lens_owner_linux.h), and the table never said so.dxr::ModeSwitchfrom displayxr-common: ramp disparity to 0, then request 2D; request 3D, then ramp up. So a harsh switch on any arm, macOS on the Odyssey included, is diagnosed in the app first. The runtime's app linter now flags apps that skip the sequencer (INV-2.9).Companion PRs: DisplayXR/displayxr-common#73 (the one-call
ModeSwitch::step()+ README contract) and the runtime PR that moves the macOS test apps onto it.🤖 Generated with Claude Code