Skip to content

weave snap: grid call reports declined before the first submitted frame while the per-point call returns identity — the helper falls back to 16,641 per-point calls #1726

Description

@dfattal

Found while wiring displayxr-common v2.24.0's grid provider (PR #1725). Until a present-owner client has submitted its first frame, xrWeaveSnapWindowGridDXR reports declined (the engine has no viewing distance yet), but xrWeaveSnapWindowRectDXR cannot express a decline and returns success with the position unchanged. displayxr-common's helper then falls back to the per-point path and builds an all-allowed table with 16,641 IPC calls and no snapping. Real drags start long after the first frame, so this is a consistency bug, not a user-visible one today. Fix: make the per-point route report the same decline (spec-wise xrWeaveSnapWindowRectDXR returns XR_SUCCESS with snapped = XR_FALSE; the helper should treat that as decline too), or have the grid call return identity-without-decline in the same pre-frame state, so both routes agree. Part of #1699 / #1723.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions