Repository navigation
fix(pin-bump): watch xrt_dp_lift.h in the features gate - #1871
Merged
Merged
Conversation
v2.31.0 shipped XRT_DP_LIFT_HAS_VIEWPOINT_POLICY (#1864) in xrt_dp_lift.h, which no track listed, so the gate skipped the leia-plugin windows repin. The plug-in's viewpoint-policy code (leia-plugin#317) then compiles out at its v2.30.0 pin. Add the header to the default surface and the windows track (lift is D3D11-only, so not linux), and widen the completeness test to xrt_dp_*.h. Dry run: v2.30.0 -> v2.31.0 windows now => BUMP. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The features gate did not watch
src/xrt/include/xrt/xrt_dp_lift.h. So when v2.31.0 addedXRT_DP_LIFT_HAS_VIEWPOINT_POLICY(#1864), the leia-plugin windows repin was skipped. Plug-in #317 is merged but compiles out at its v2.30.0 pin.downstream-pins.json: add the header tofeature_surface.headersand to the leia windowsfeature_headers. Lift is D3D11-only, so the linux track is unchanged.test_downstream_pin_bump.py: the completeness test now also coversxrt_dp_*.h.Verified: the unit tests pass (16/16), and
downstream_pin_bump.py verdict --from v2.30.0 --to v2.31.0 --repo displayxr-leia-plugin --track windowsnow returns BUMP (trigger: the new macro).🤖 Generated with Claude Code