chore: bump the plugin pin from v2.12.1 to v2.14.0 in all four samples - #12
Merged
Merged
Conversation
The samples are the regression net for the plugin, so leaving them two releases behind means they net the wrong version. v2.12.1 predates v2.13.0/1/2 and v2.14.0. Notable for these projects specifically: - v2.14.0 adds DisplayXRSceneMode (2D scenes) and ships the window-space-UI mouse router as Samples~/WindowSpaceUI. The urp- and hdrp-singlepass-ui projects each carry their own copy of DisplayXRWsuiMouseRouter.cs; those can now be dropped in favour of the packaged sample, but that is a separate change and is deliberately not done here. - v2.13.2 fixes the boot-splash guard that made the packaged setup scripts create nothing. - v2.13.1 fixes the transparent-overlay hit mask clipping the picture, which desktop-avatar is the sample most affected by. No packages-lock.json change: these projects do not carry a lock entry for com.displayxr.unity, so the manifest is the only pin. Not verified by opening the projects — no Unity licence on the box that would let CI do it, and I have no panel here to check rendering. Worth a pass on desktop-avatar in particular before relying on it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017gcLGQ4WAPj41Wspz6WEKW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The samples are the plugin's regression net (per the plugin's
CLAUDE.md), so leaving them two releases behind means they net the wrong version. All four were on#upm/v2.12.1, which predates v2.13.0, v2.13.1, v2.13.2 and v2.14.0.What they pick up
DisplayXRSceneMode(2D scenes, #267) and the window-space-UI mouse router shipped asSamples~/WindowSpaceUI(#268); edit-mode framing preview for the display-centric rig (#265)desktop-avataris the sample most exposed to thisDeliberately not done here
urp-singlepass-uiandhdrp-singlepass-uieach carry their own copy ofDisplayXRWsuiMouseRouter.cs. v2.14.0 ships that router as a package sample, so those copies can be dropped in favour of the packaged one — but that changes what the samples actually exercise, so it belongs in its own change rather than riding along with a version bump.Notes
packages-lock.jsonchange. These projects carry no lock entry forcom.displayxr.unity, so the manifest is the only pin. (Worth stating explicitly, since bumps here have historically needed a lock refresh.)desktop-avataris the one I'd want a human pass on — it's the transparent-overlay sample and therefore the most exposed to the v2.13.1 mask change.🤖 Generated with Claude Code
https://claude.ai/code/session_017gcLGQ4WAPj41Wspz6WEKW