chore: bump the plugin pin to v2.19.1 in all four samples - #15
Merged
Merged
Conversation
All four samples now pin com.displayxr.unity at #upm/v2.19.1
(UPM resolves it to 77eaebf63b334fe6ddc94eb03ed30d9094441a8f). The three
non-avatar samples move up from v2.14.0; desktop-avatar moves from the
v2.19.0 pin that landed with the rear-depth-budget content-bounds work.
packages-lock.json for birp-multipass, urp-singlepass-ui and
hdrp-singlepass-ui is whatever Unity wrote during the build, not a hand
edit.
Unity also pruned a dead feature reference from two OpenXR settings assets
(desktop-avatar and urp-singlepass-ui): the features list still carried
`{fileID: -447193531061196479}`, a DisplayXRFeature object whose script was
deleted from the plug-in back in v2.0.0. The MonoBehaviour block itself is
still in the file; only the dangling list entry is gone, which is the
correct resolution. birp-multipass and hdrp-singlepass-ui had no such list
entry to prune.
All four players rebuilt clean on Unity 6000.4.0f1 (batchmode, "Build
Finished, Result: Success", no error CS), and in each one the bundled
displayxr_unity.dll is byte-identical (SHA256
3809236a008d61ffec0d9311895dee032342630347739dcc79876b42cd423a6f) to the
DLL in that project's com.displayxr.unity@77eaebf63b33 package cache, and
Authenticode-Valid, signed by Leia, Inc.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012co2j1fdmZ2AdEAp4Y3xpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps
com.displayxr.unityto the released#upm/v2.19.1tag in all four samples, and commits the resolution UPM produced (packages-lock.jsonhash77eaebf63b334fe6ddc94eb03ed30d9094441a8f).birp-multipassv2.14.0v2.19.1urp-singlepass-uiv2.14.0v2.19.1hdrp-singlepass-uiv2.14.0v2.19.1desktop-avatarv2.19.0v2.19.1The three non-avatar
packages-lock.jsonfiles are exactly what Unity wrote during the build — no hand edits.desktop-avatar's lock was already resolved at v2.19.1 locally and is the same shape as the v2.19.0 entry it replaces.Unity-pruned dead DisplayXRFeature refs
Two
Assets/XR/Settings/OpenXR Package Settings.assetfiles (desktop-avatar,urp-singlepass-ui) still carried a dangling entry in theOpenXRSettings.featureslist:That object is a
DisplayXRFeaturewhose backing script was deleted from the plug-in in v2.0.0, so the reference has pointed at nothing for a long time. Opening the projects against v2.19.1 made Unity drop the list entry (theMonoBehaviourblock itself stays in the file). This is the correct resolution and is included deliberately.birp-multipassandhdrp-singlepass-uihad no such list entry.Nothing else is in this PR — incidental editor churn (an HDRP
m_RuntimeSettingsrepopulation, and CRLF-only rewrites of severalProjectSettings/*.asset) was discarded.Verification
All four players rebuilt headless on Unity
6000.4.0f1via each sample'sunity_build.bat, default variant:birp-multipassDisplayXR-BiRP-MultiPass.exeurp-singlepass-uiDisplayXR-URP-SinglePass-UI.exehdrp-singlepass-uiDisplayXR-HDRP-SinglePass-UI.exedesktop-avatarDisplayXR-DesktopAvatar.exeNo
error CS, noBuild failed, no DisplayXR-related error in any log. The only DisplayXR-tagged warnings are pre-existingCS0618obsolescence notices onFindObjectsByType(FindObjectsSortMode)inbirp-multipass'sDisplayXRInputController.cs.The players really carry the v2.19.1 native plug-in. In each sample,
…_Data/Plugins/x86_64/displayxr_unity.dllis byte-identical toLibrary/PackageCache/com.displayxr.unity@77eaebf63b33/Runtime/Plugins/Windows/x64/displayxr_unity.dll:and Authenticode Valid, signed by
CN="Leia, Inc.". The DLL carries no version resource (FileVersionis empty, raw0.0.0.0), so the package-cache commit hash plus the SHA256 are the identity evidence.No installer builds were run, and no player was launched.
🤖 Generated with Claude Code
https://claude.ai/code/session_012co2j1fdmZ2AdEAp4Y3xpp