Repository navigation
fix(cursor-depth): hybrid keeps the line of sight — release 1.37.1 - #145
Merged
Merged
Conversation
…e foot) A depth change under a still pointer lifted the sprite along the display normal, pulling it off the click point for an off-axis viewer (found by the runtime agent's off-axis capture: 27 px). Keep E0->S0 from the last pointer move and sit on it at the current depth. Head moves: fixed (parallax). Depth changes: along the line (stays on the click point). Continuous at the stop. Release 1.37.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 1.37.0's hybrid anchor, when the depth under a still pointer changed, the sprite rose along the display normal. For an off-axis viewer that pulls it off the click point (27 px in the runtime's off-axis capture). It now keeps the line of sight from the last pointer move and sits on that line at the current depth:
This is the same rule the runtime adopts (DisplayXR/displayxr-runtime#1847).
Evidence:
npm test: 849 pass. Two new tests: an off-axis depth change, where the sprite stays exactly on the click point while world mode drifts more than 5 mm, and a head moving nearer, where the sprite keeps the depth the content needs.test:e2e:cursor: 6/6 pass (both engines, model and splat; screen still slides, hybrid and world stay fixed).Bumps to 1.37.1. After merge, tag
sdk-v1.37.1.🤖 Generated with Claude Code