Skip to content

test(e2e): 3D scene samples on a real panel + display-modes startup read fix #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dfattal merged 5 commits into from
Oct 8, 2026
Merged

test(e2e): 3D scene samples on a real panel + display-modes startup read fix #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f7bae6b
test(e2e): the 3D scene samples on a real panel, in the DisplayXR Bro…
leaiss Oct 8, 2026
18a1688
fix(display-modes): read the display after the first woven frame
leaiss Oct 8, 2026
2d79dec
test(e2e): make the console-error check able to fire
leaiss Oct 8, 2026
bd969e6
test(e2e): media, call and shop samples on the panel (player, shopify…
leaiss Oct 8, 2026
464525c
test(e2e): check the woven picture, not just that a weave was asked for
leaiss Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,6 @@ package-lock.json
# Bundler smoke tests (test/bundlers): installed tools and build output, never committed
test/bundlers/node_modules/
test/bundlers/out/

# Panel e2e run output (test/e2e/samples-panel.e2e.mjs): screenshots, logs, results
test/e2e/out/
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@
"test:e2e": "node test/e2e/call-element.e2e.mjs",
"test:e2e:camera": "node test/e2e/camera.e2e.mjs",
"test:e2e:cursor": "node test/e2e/cursor-depth.e2e.mjs",
"test:e2e:samples-panel": "node test/e2e/samples-panel.e2e.mjs",
"api:check": "node tools/api-surface.mjs --check",
"api:update": "node tools/api-surface.mjs --update",
"check:snippets": "node tools/check-snippets.mjs",
Expand Down
3 changes: 3 additions & 0 deletions samples/display-modes/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,9 @@ async function toggleStereo() {
});

try {
// The layer answers display reads only once it has delivered a frame: read before that and
// getDisplayInfo() is null and getRenderingModes() empty, which reads as "no display".
await handle.firstWoven;
await readDisplayInfo();
await readModes();
} catch (e) {
Expand Down
Loading
Loading