Hardening security: role enforcement, tenant isolation, rate limiting… - #1
Open
MABDesigns wants to merge 1 commit into
Open
Hardening security: role enforcement, tenant isolation, rate limiting…#1MABDesigns wants to merge 1 commit into
MABDesigns wants to merge 1 commit into
Conversation
…, and JWT improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Hardening and Multi-Tenancy Protection 🛡️
This PR implements a comprehensive security audit and remediation suite to harden the API infrastructure, ensure robust tenant isolation, and protect against common attack vectors.
📋 Key Improvements
1. Multi-Tenancy & Access Control
revenue-by-tenantreport strictly to thesuperadminrole.ReportControllerto prevent access even if routing filters are bypassed.Orders,Products) strictly useresolveTenantId()to filter data by the authenticated user's organization.2. Brute-Force Mitigation
loginandrefreshendpoints (max 5 requests per minute).3. JWT Infrastructure Hardening
change-me-in-productionfallback. The system now requires a validJWT_SECRETin the environment.Invalid or expired tokenmessage instead of raw library exceptions.4. Protocol Integrity
ContentTypeFilterthat mandatesapplication/jsonfor all data-modifying requests (POST,PUT,PATCH), preventing payload injection attacks.This PR removes the insecure fallback secret for JWT. All developers and environments must update their
.envfile to include a strong, uniqueJWT_SECRET.Important
If
JWT_SECRETis missing or set tochange-me-in-production, the API will throw aRuntimeExceptionand refuse to start. This is a deliberate "Fail Fast" mechanism to prevent insecure deployments.