Bubbler scrambler - IGNORE TB#11
Open
doc4science wants to merge 15 commits into
Open
Conversation
Jcb-Jcb
reviewed
Mar 2, 2026
Jcb-Jcb
reviewed
Apr 26, 2026
| end | ||
| end | ||
|
|
||
| always_ff @(posedge clk) begin |
Collaborator
There was a problem hiding this comment.
The output port signals (_66b_o, valid_o) should technically use the pipeline module instead of a clocked block
| end | ||
| end | ||
|
|
||
| assign _66b_o = output_q; |
Collaborator
There was a problem hiding this comment.
This seems unnecessary, just clock the outputs directly
|
|
||
| always_ff @(posedge clk) begin | ||
| if(rst == 1'b1)begin | ||
| output_q <= '0; |
Collaborator
There was a problem hiding this comment.
Also just reset valid_o to 0. That tells nextr module that the data isn't valid, it doesn't matter what the output data is if valid = 0. (better for routing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bubbler and Scrambler RTL, untested.
Ignore the TB files - they are NOT complete. RTL has not been run and likely contains errors.