Repository navigation
fix: make privacy disclosures accessible and accurate - #386
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds a direct privacy-policy link to Settings, server selection, sign-in, and owner setup, plus the web account menu. The link is independent of account permissions and connection mode and uses the existing external-browser navigation convention.
Corrects the privacy policy's absolute reading-log assurance to explain optional scoped external access, recipient choice, the information shared, retention implications, and the limits of token revocation. Existing consent and revocation controls are preserved.
Why
The published policy was not directly accessible in the app and did not describe optional sharing of listening history and book text. This addresses the two privacy-disclosure findings from the Apple policy review. It does not change account deletion, store metadata, or native privacy manifests.
Screenshots
Synthetic browser fixtures, including the native frontend shell; these are not device captures. Before uses baseline a6e51c0; after uses this branch.
Testing
Local: web lint, all 800 unit tests, production web build, and 10 focused browser navigation tests pass. The navigation tests exercise sign-in/setup, connected, demo, device-only and server-selection states; clicking the policy opens the expected external destination while preserving the original screen and form values. The destination response is intercepted in these tests; the published policy URL was separately checked for reachability.
The complete local browser lifecycle gate passed: 223 tests, including the 10 privacy navigation cases. Lint and production build were rerun after the final styling change and passed. Native external-navigation behavior was inspected in source, but iOS/Android/macOS runtime and physical-device checks were not performed. The policy remains a hosted page and requires network access to load. The revised policy is not published until this change is merged and the docs deployment completes.