Grantite docling and granite 4 vision - #18
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f288af0583
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let vision_tower = siglip::VisionModel::new( | ||
| &cfg.vision_config, | ||
| false, | ||
| vb.pp("vision_tower.vision_model"), |
There was a problem hiding this comment.
model.-prefixed weights
The constructor loads SigLIP tensors from vb.pp("vision_tower.vision_model"), but the Granite 4 Vision checkpoint stores these parameters under model.vision_tower.vision_model (consistent with how this same constructor loads model.layerwise_projectors, model.spatial_projectors, and model.language_model). With official model.safetensors shards, this prefix mismatch causes missing-tensor errors during model initialization, so the example cannot load the model.
Useful? React with 👍 / 👎.
…rent_w - 2*padding; flakey tests
1 participant
No description provided.