Decompile 59EA0, 5D120, 5E230, 60CF0, and map .rodata#34
Open
queueRAM wants to merge 6 commits into
Open
Conversation
queueRAM
changed the title
queueRAM
changed the title
Drahsid
reviewed
Jun 30, 2026
Drahsid
left a comment
Drahsid
left a comment
Owner
There was a problem hiding this comment.
do this match when using the base address and correcting the indices?
- Decompile 59EA0 - Decompile 5D120 - Map .rodata for 59EA0 Co-authored-by: Dominik Peters <github@d-peters.com> Co-authored-by: inspectredc <78732756+inspectredc@users.noreply.github.com>
Co-authored-by: Drahsid <Drahsid@gmail.com> Co-authored-by: Dominik Peters <github@d-peters.com>
- Add overlays.h and add OVERLAY#_DISPATCH_TABLE_VRAM - Correct 5E230 dispatch table calls to use overlay indexes - Cleanup code comments
queueRAM
force-pushed
the
decomp_59EA0_5D120
branch
from
e5c5c2d to
76d43e1
Compare
Drahsid
reviewed
Jun 30, 2026
Comment on lines
+103
to
+135
| void func_8005C8A4(void) { | ||
| if (gCamShakeTime == 0) { | ||
| gCamShakeV = 0; | ||
| } | ||
| else { | ||
| if (!(gCamShakeTime & 1)) { | ||
| gCamShakeV = gCamShakeMag / 0x10000; | ||
| } | ||
| else { | ||
| gCamShakeV = -gCamShakeMag / 0x10000; | ||
| } | ||
| gCamShakeTime--; | ||
| switch (gCamShakeType) { | ||
| case 1: | ||
| if (!(gCamShakeTime & 1)) { | ||
| gCamShakeMag -= gCamShakeMagDelta * 2; | ||
| } | ||
| break; | ||
| case 2: | ||
| if (!(gCamShakeTime & 2)) { | ||
| gCamShakeV = func_8005C708(gCamShakeMag / 0x10000); | ||
| } | ||
| break; | ||
| default: | ||
| gCamShakeMag -= gCamShakeMagDelta; | ||
| break; | ||
| } | ||
| if (((D_800CCC78[8 * gCurrentScene] == 1) && (gCamShakeV < 0)) || | ||
| ((D_800CCC78[8 * gCurrentScene] == 2) && (gCamShakeV > 0))) { | ||
| gCamShakeV = 0; | ||
| } | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
gCamShakeMag / 0x10000 looks like fixed point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.