Fix cross-platform CMake workflow configuration in GitHub Actions matrix - #19
Merged
Merged
Conversation
Co-authored-by: PR3C14D0 <60857589+PR3C14D0@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
PR3C14D0
August 11, 2026 19:50
View session
PR3C14D0
marked this pull request as ready for review
August 11, 2026 19:50
Up to standards ✅🟢 Issues
|
Member
|
@copilot CI Builds failing on ubuntu and macOS, Windows untested |
Co-authored-by: PR3C14D0 <60857589+PR3C14D0@users.noreply.github.com>
Contributor
Author
Addressed in 364a7e5. I updated the workflow to detect the vcpkg manifest path (root or Engine), explicitly install manifest dependencies on all OSes before configure, and set VULKAN_SDK on macOS from molten-vk so FindVulkan resolves correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build matrix was failing across macOS, Linux, and Windows due to inconsistent toolchain/bootstrap setup and invalid platform-specific dependency installation. This change aligns CI configuration with the project’s vcpkg-based dependency model and ensures each runner can configure CMake successfully.
Workflow: normalize dependency/toolchain setup by platform
ilammy/msvc-dev-cmd@v1socl.exeis available during CMake configure.VCPKG_ROOTand PATH consistently for non-Windows runners.Workflow: remove brittle package-manager assumptions
stb) from macOS install step.ninja-build,libvulkan-dev,glslang-tools), letting vcpkg resolve project libraries.CMake presets: make non-Windows builds use vcpkg toolchain
CMAKE_TOOLCHAIN_FILE=$env{VCPKG_ROOT}/scripts/buildsystems/vcpkg.cmaketolinux-baseandmacos-basepresets.