Let /podcasts be the Podcasts page it now has - #92
Merged
Conversation
LEGACY_SECTION_SLUGS redirects a dead WordPress category archive to the section that absorbed it, and it carried one entry: /podcasts -> /columns, from when Podcasts existed only as a category_aliases entry on Columns. Podcasts has a subsection row now, with 75 articles and a page of its own. The redirect runs in middleware, ahead of routing, so it shadowed that page completely: every request for /podcasts still landed on /columns, and the count on the sections screen was the only visible sign the page existed. The module's own comment called this out -- "if a slug here is ever given a real taxonomy row, remove it from this map" -- so this is that removal. The map is now empty, which is the healthy state: every WordPress sub-category the migration left behind has a row. The mechanism stays for the next one. Checked the other 47 seeded slugs against production first; /podcasts was the only one shadowed. /wrestling, /editorial and /mens-lacrosse were already serving their own pages. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
podcastsreports 75 articles on the CMS sections screen, and/podcastson the site serves none of them — it 301s to/columns.Cause
LEGACY_SECTION_SLUGSmaps dead WordPress category archives to whichever section absorbed them, and it held exactly one entry:podcasts: "/columns", added when Podcasts existed only as acategory_aliasesentry on Columns.DrexelTriangle/triangle-cms#215 gave Podcasts a subsection row with a page of its own. The redirect runs in middleware, ahead of routing, so it shadows that page completely — every request for
/podcastsstill lands on/columns, and the article count in the CMS was the only visible sign the page existed.The module's own comment predicted this:
So this is that removal.
Scope
I checked all 48 seeded slugs against production before assuming this was isolated.
/podcastswas the only one shadowed:Why keep an empty map
The mechanism is still right for the next WordPress archive that needs it, and the file carries the reasoning for when to add an entry versus when to create a taxonomy row instead. Empty is now the healthy state — every sub-category the migration left behind has a row.
Testing
eslintclean,astro check0 errors / 0 warnings. Ran the site locally against the production CMS API over an SSH tunnel:/podcastsreturns 200, titles as "Podcasts - The Triangle", and renders 34 article links instead of redirecting.🤖 Generated with Claude Code