Link a subsection's own children in the nav strip - #94
Merged
Conversation
The CMS taxonomy is three levels now: A&E holds Food, and Food holds Beer Reviews, Wine Reviews, Restaurant Reviews and Cooking. A subsection page hardcoded an empty strip on the premise that a subsection had no children to show, so /food would have listed its articles with no way to reach the four categories beneath it. Both kinds of page read the same field, which the CMS now sets on subsection responses too. It is absent or empty for the leaf subsections -- still most of them -- and the strip then renders as nothing exactly as it did before. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CMS taxonomy is three levels now: A&E holds Food, and Food holds Beer Reviews, Wine Reviews, Restaurant Reviews and Cooking.
A subsection page hardcoded an empty strip, on the premise that a subsection had no children to show. So
/foodwould have listed its articles with no way to reach the four categories beneath it.Both kinds of page now read the same
subsectionsfield, which the CMS sets on subsection responses too. It is absent or empty for the leaf subsections — still most of them — and the strip then renders as nothing, exactly as before.Depends on DrexelTriangle/triangle-cms#216, which is what populates the field. Until that ships this is a no-op: the field is simply absent and
?? []covers it.astro checkclean.🤖 Generated with Claude Code