Regenerate the Swagger spec so main goes green - #229
Merged
Conversation
swaggo copies Go doc comments into the spec, so shortening the WindowHours comment on BreakingNewsState left server/docs stale and ci.yml's swagger-docs job failed on the diff. Regenerated with the pinned swag v1.16.6 from server/Dockerfile. Only that one description changes, in all three generated files. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L4qBhBdQto1yNp1zP7VLYc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis red. #228 was merged about a minute after it opened, while CI wasstill running, and its
swagger-docsjob then failed:Publish ImagesandDeploy Deltaare gated on a successful CI run, so bothwere skipped: the merge is on
mainbut nothing has deployed.Cause
swaggo copies Go doc comments into the generated spec. #228 shortened the
WindowHourscomment onmodels.BreakingNewsState, which changes thewindow_hoursdescription indocs.go,swagger.jsonandswagger.yaml.The Docker build regenerates the spec, so the shipped binary was always
correct; the committed copy that
pages.ymlpublishes was the stale one.Fix
Regenerated with the pinned
swag v1.16.6fromserver/Dockerfile. Onedescription string changes, in all three generated files. Nothing else.
Verified locally:
swag init --parseDependency --parseInternalnow produces nodiff, and
go build,go vetandgo test ./...pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01L4qBhBdQto1yNp1zP7VLYc