Refactor inventory and item equip flow#28
Merged
Conversation
naviGateauR
approved these changes
Jun 9, 2026
naviGateauR
left a comment
Collaborator
There was a problem hiding this comment.
Looks all good to me. I can see the changes in the code align with the documentation on SwaggerUI.
I was also able to test both the GET and POST endpoint of the Shop.
No issues.
There is a conflict with the database.sqlite though. How do we want to resolve it ?
user the one from the main branch and not merge it ?
Collaborator
Author
I can we can just delete database from this branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
forloopChanges
authService.jsforEachwithforloop ingetInventoryeggService.jsshopService.jsTest
How to test
npm installandnpm start