Test the platforms the shell ships binaries for, and add the rest - #2
Merged
Conversation
release-app.yml builds Windows and macOS binaries; nothing ran the library underneath them on either platform. CI was one job doing five things on Linux, with actions two majors behind. - lint split from test, so a ruff failure is not reported as a test failure three times over - the suite on Windows and macOS - a build job that installs the wheel into a clean environment: the distribution is glia-agents and the import package is glia, and that mismatch is the packaging mistake nobody catches locally - an aggregate CI job for branch protection - CodeQL, Dependabot, auto-merge for patch and action bumps, pre-commit - actions to current majors across all four workflows The coverage gate and the examples loop stay on Linux only. Measuring them three times says nothing new.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
PR #1 has been open since 3 August with that file. Duplicating it here would have made whichever merged second a conflict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
glia had one job doing five things on Linux only, and actions two majors
behind. The shell ships Windows and macOS binaries from
release-app.yml, andnothing tested the library underneath them on either platform.
lintsplit out fromtest, so a ruff failure is not reported as a testfailure across three Python versions at once
platforms: the suite on Windows and macOS, 3.12build: installs the wheel into a clean venv, importsgliaand runsglia-shell --help. The distribution isglia-agentsand the import packageis
glia— that mismatch is the packaging mistake nobody catches locallyCIjob, so branch protection has one check to requirecodeql.yml,dependabot-auto-merge.yml,.pre-commit-config.yamlpermissions: contents: readat workflow levelci.yml,docs.yml,publish.ymlandrelease-app.ymlNo
dependabot.ymlhere. #1 has been open since 3 August with that file,alongside the link corrections. This branch defers to it; the auto-merge
workflow reads its rules.
The coverage gate (
--cov-fail-under=90) and the examples loop still run once,on Linux. Measuring them three times says nothing new.
Why
Six of seven repositories were missing some part of this. This is the pass that
makes them the same.
What breaks if this is wrong
The Windows and macOS jobs are the new claim here. The suite is offline and
the core has no required dependencies, so it should pass — and on the first run
it did, which is the only evidence that counts.
glia-shell --helpin the build job. It resolves through argparse andexits 0. If a future change makes
main()open a window before parsingarguments, this step hangs rather than fails, and that is the failure mode to
watch for.
Auto-merge covers action bumps and patch bumps only; minor and major keep a
human. It does nothing until #1 lands and branch protection is on.
Checklist
ruff check .passes locally