Point every reference at the organisation, not the old account - #3
Closed
DenisDrobyshev wants to merge 1 commit into
Closed
Point every reference at the organisation, not the old account#3DenisDrobyshev wants to merge 1 commit into
DenisDrobyshev wants to merge 1 commit into
Conversation
Seventeen links still name DenisDrobyshev/glia. GitHub redirects a moved repository, so none of them look broken. PyPI does not. Trusted Publishing matches owner, repository and workflow filename exactly against what is registered, and glia-agents 0.8.2 was registered from the old account. The next release will be rejected until the publisher is updated on PyPI - which this commit cannot do, only record.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Seventeen references still point at
DenisDrobyshev/glia. The repository livesat
DrobyshevDev/glia. Badges, clone commands, release links,mkdocs.yml,and the three
[project.urls]entries that PyPI renders on the project page.Why
GitHub redirects a moved repository, so most of these still resolve and none of
them look broken. One does not redirect, and it is the one that matters:
PyPI Trusted Publishing matches the workflow's owner, repository and filename
exactly against what is registered.
glia-agents0.8.2 is already on PyPI, sothat registration was made from the old account. The next release from this
repository will be rejected by PyPI until the trusted publisher is updated,
and the failure arrives after a tag is pushed and a release is published —
the worst moment to discover it.
This pull request corrects the comment. It cannot correct PyPI.
Action required outside this repository
At https://pypi.org/manage/project/glia-agents/settings/publishing/ — change the
publisher's owner from
DenisDrobyshevtoDrobyshevDev. Repository name(
glia), workflow (publish.yml) and environment stay as they are. Until thatis done,
publish.ymlis decoration.What breaks if this is wrong
Nothing executable. The rewrite is narrow: only the exact string
DenisDrobyshev/gliawas replaced, so a legitimate mention of the personalaccount elsewhere is untouched.
praxismentions the author by name in proseand was deliberately left alone for that reason.
Checklist
DenisDrobyshev/gliarewritten, nothing broader