v1.6.2 — fix stale tile cache + dead CARTO allowlist left over from v1.6.1 - #11
Merged
Merged
Conversation
…vas zoom v1.6.1 swapped the map's light/dark tile provider from CARTO to Esri (fixing the "API KEY REQUIRED" watermark) but missed three follow-on details: - The service worker's separate tile cache (TILE) was never bumped. That cache is deliberately excluded from the SW activate handler's cleanup so offline map areas keep working — but that also means it outlives every CN bump. Bumped it now so it doesn't keep accumulating dead entries under the old cartocdn.com URLs. - CSP img-src and the SW's tile-cache hostname check still allowlisted basemaps.cartocdn.com, unused since the switch. Removed. - The Esri Canvas base+reference layers don't have real tile coverage past zoom ~16 in most regions (unlike World_Imagery). Added maxNativeZoom:16 so Leaflet upscales the deepest real tile instead of requesting tiles Esri doesn't reliably serve. Verified in-browser: light/dark/satellite all render cleanly, deep zoom upscales without blank tiles, 91 unit + 12 integration tests pass. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v1.6.1 (
545ab08) swapped the map's light/dark tile provider from CARTO to Esri, fixing the "API KEY REQUIRED" watermark. This PR closes three gaps that fix left behind:TILE) was never bumped. That cache is deliberately excluded from theactivatehandler's cleanup so offline map areas keep working — but that also means it survives everyCNbump. It was stillred-alert-tiles-v1, the same version used while CARTO's watermarked tiles were being cached. Bumped tov2.basemaps.cartocdn.comallowlist entries left in CSPimg-srcand the SW's tile-cache hostname check, unused since v1.6.1. Removed —server.arcgisonline.comis now the only tile host anywhere in the app.maxNativeZoomon the Esri Canvas base+reference layers. UnlikeWorld_Imagery, their real tile coverage tops out around zoom 16 in most regions — without a cap, Leaflet would request deeper tiles Esri doesn't reliably serve. AddedmaxNativeZoom:16so Leaflet upscales the last real tile instead.Also bumped
CN(v16→v17, since index.html changed),APP_VERSION/package.json/CHANGES/CHANGELOG.mdto 1.6.2, and refreshed the CLAUDE.md/AGENTS.md map + PWA sections (their version numbers had drifted stale across several priorCNbumps, and neither doc mentioned theTILE-never-auto-clears caveat — plausibly why it got missed in v1.6.1).Test plan
node test/unit.js— 91/91 passnode test/integration.js— 12/12 passmaxNativeZoom:16applied to both the base and reference Canvas layers; zoomed to 18 in Tel Aviv — basemap upscales cleanly, no blank tilescartocdn.comanywhere in the repo (only explanatory history comments)🤖 Generated with Claude Code