Repository navigation
feat: add focus workout view - #222
giulioleuci wants to merge 5 commits into
Conversation
|
Implement #221 |
|
Do you have screenshots of what this looks like? |
|
I added two images to the PR message. In my app, I only have this view because it works well for me. https://github.com/giulioleuci/test-app-workout-alpha |
|
How does this work with timed exercises? |
|
I have updated the screenshots in the PR to visually demonstrate this UI behavior. In the Focus view for timed sets ( Tapping Start triggers an interactive on-screen countdown timer. Once the timer completes—or if the user stops it early—the app automatically captures and logs the exact duration held (for instance, recording 38 seconds if stopped early instead of the target 45 seconds). Upon logging, a brief "Hold logged" notification appears, and the app smoothly transitions into the standard post-set routine, whether that means initiating the rest timer, advancing to the next exercise in a superset, or prompting workout completion. Ultimately, timed sets fit right into the existing completion workflow; they simply replace manual rep logging with a guided countdown experience. |
44c03ee to
9133469
Compare
|
Thanks @giulioleuci, and for the screenshots. A focus view makes sense to me. It wasn't in v1.3.9 because the workout screen changed a lot in this release (plan line, keyboard shortcuts, rest pause, per-exercise "Don't count for progression", swipe preview, plate lines), so it needs a rebase onto v1.3.9. For the next round: every new string in all locale packs (the check fails otherwise), no |
ec24b1a to
d71fa08
Compare
|
Hi @DuarteSantos8 ,
|
d71fa08 to
19a28ff
Compare
…n the focus view The focus view was missing what the card view already showed: the planned sets and reps beside today's prescription, the plate stack (and what is short) under each set, and the per-exercise switch that keeps an exercise out of the progression. A burst now takes its rest from the exercise's rest-pause setting when there is one, instead of the global default. Focus and card views share the key handler, so the Enter/Space case is asserted in both. Drops the design spec: it is agent scratch, like the gitignored plans/ folder next to it.
Rest start carries the set it follows, the en dash for an empty value, the Layout menu test follows the grouped menu, zh-TW gets the focus strings and the stale em-dash duplicate of the minimum-duration message is dropped. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
19a28ff to
5ce543e
Compare
# Conflicts: # frontend/src/locales/ar.js # frontend/src/locales/de.js # frontend/src/locales/es.js # frontend/src/locales/fr.js # frontend/src/locales/hi.js # frontend/src/locales/hu.js # frontend/src/locales/it.js # frontend/src/locales/ko.js # frontend/src/locales/pl.js # frontend/src/locales/pt-BR.js # frontend/src/locales/pt.js # frontend/src/locales/ru.js # frontend/src/locales/th.js # frontend/src/locales/tr.js # frontend/src/locales/uk.js # frontend/src/locales/zh-TW.js # frontend/src/locales/zh.js # frontend/src/views/Workout.jsx
… after merging DuarteSantos8#222 with the superset move fix
|
Merged into v1.4.0, thanks @giulioleuci! |
Closes #221
Implements the Focus workout view — a fourth, purely presentational layout for the active workout screen, one set at a time.
What this adds
togglepath — sound, haptics, rest timer, progression, high-water protection all shared with the other layouts; Skip advances without completing; a footer pager (chevrons + one dot per set) navigates directly.Segmentedand to the header ⋮ layout menu; the choice snapshots ontos.active.workoutViewand falls back tocardsfor unknown values.Not in scope
s.activesession.Stepper/Slidergained optionaldisabled/onStep/ariaLabelprops to power the focus card; all existing layouts render as before.Tests
workout focus viewdescribe block inWorkout.test.jsx(focus rendering, set navigation, completion auto-advance, superset round flow, unilateral sets).Settings.workoutview.test.jsx,sheets.workoutview.test.jsx,ui.test.jsxfor the 4-way control and the new Stepper/Slider props.