Repository navigation
fix: let users hide the sync banner - #382
Closed
SomSamantray wants to merge 2 commits into
Closed
SomSamantray wants to merge 2 commits into
SomSamantray wants to merge 2 commits into
Conversation
Owner
|
Thanks @SomSamantray! This got covered by #330 in v1.3.10, so closing this one. https://github.com/DuarteSantos8/openGym/releases/tag/v1.3.10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users can now hide the sync banner in Settings, and the choice stays on that device. The banner remains visible by default, and connection status remains available in Settings.
Fixes #330 and #369.
Validation
All 3,164 frontend tests pass, the locale check passes for all 16 locales, and the production build succeeds. I also turned the setting off in the browser and confirmed it stayed off after reload.
AI disclosure
OpenAI Codex assisted with issue analysis, implementation, and testing. The change was reviewed against the repository guidance and verified locally.