Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds footstep sound customization support to the mod, allowing modelers to configure custom footstep sounds for different ground materials and movement states. The update introduces 16 new sound tags covering organic, mechanical, danger, and no-sound materials, each with light/heavy walking and running variants.
- Added
AudioUtilsutility class for playing audio with automatic temporary object cleanup - Implemented
AudioManagerOnFootStepSoundPatchto intercept and replace footstep sounds with custom variants - Improved death sound playback to use temporary objects for proper cleanup
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| DuckovCustomModel/Utils/AudioUtils.cs | New utility class for playing audio with automatic cleanup of temporary GameObject |
| DuckovCustomModel/MonoBehaviours/ModelHandler.cs | Updated death sound handler to use AudioUtils for proper cleanup |
| DuckovCustomModel/HarmonyPatches/AudioManagerPatches.cs | Added footstep sound patch and renamed existing patches for clarity |
| DuckovCustomModel.Core/Data/SoundTags.cs | Added 16 new footstep sound tag constants for different materials and movement states |
| DuckovCustomModel/Constant.cs | Updated version to 1.8.4 |
| README.md & README_EN.md | Added documentation for footstep sound tags and trigger mechanism |
| CHANGELOG.md & CHANGELOG_EN.md | Added v1.8.4 release notes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- 新增16个脚步声音效标签，支持不同材质和状态的脚步声配置 - 新增AudioUtils工具类，用于播放音频并自动清理临时对象 - 新增AudioManagerOnFootStepSoundPatch补丁，处理自定义脚步声 - 改进死亡音效播放逻辑，使用临时对象确保正确播放和清理 - 改进AudioUtils错误处理和代码健壮性 - 更新版本号至 v1.8.4 - 更新 CHANGELOG 和 README
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
更新内容
footstep_organic_walk_light、footstep_organic_walk_heavy、footstep_organic_run_light、footstep_organic_run_heavy等AudioUtils工具类，用于播放音频并自动清理临时对象AudioManagerOnFootStepSoundPatch补丁，处理自定义脚步声版本更新