Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes an error in both the Chinese and English README files regarding the behavior of the SoundTagPlayChance configuration. The original documentation incorrectly stated that when the probability is 0 or not configured, the sound always plays. Based on the code logic at ModelHandler.cs:1118, the correct behavior is:
- If not configured: always plays (default behavior)
- If probability is 0: never plays
Key Changes
- Separated the documentation for unconfigured probability and zero probability into two distinct bullet points
- Corrected the behavior description for probability = 0 from "always plays" to "never plays"
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Fixed Chinese documentation to correctly describe that probability 0 means never play |
| README_EN.md | Fixed English documentation to correctly describe that probability 0 means never play |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复了README中关于音频概率0的错误说明。根据代码逻辑，当概率为0时应该始终不播放，而不是始终播放。