Fix/master audit findings - #20
Merged
Merged
Conversation
added 8 commits
August 18, 2026 09:45
The #if (dapper) block sat at literal EOF; when dapper=false the template engine's conditional stripper left a dangling #endif, producing CS1028 for every combination without --dapper — including the default invocation with no flags at all, the most common path a new user takes.
…nflict Unlike Unexpected errors, ErrorType.Conflict is treated as caller-authored by the AspNetCore mapping and passed straight through to the HTTP response. The concurrency-conflict message must stay safe to show a client instead of carrying EF's internal exception text.
… its real floor Verified via clean-restore (isolated NuGet cache): the actual transitive floor from Microsoft.Extensions.Caching.Hybrid -> Logging.Abstractions is 9.0.19, not the previously pinned 10.0.11. Pinning at the exact floor keeps this package's version much closer to the rest of the family (9.0.18).
MapAsync/BindAsync/EnsureAsync now accept an optional trailing ct, checked right after the awaited resultTask and before the mapper/binder/predicate runs. Additive, backward-compatible.
…t path Drives an actual DbUpdateConcurrencyException via a concurrency-token property on the InMemory provider (two contexts racing the same row), rather than only the general DbUpdateException branch.
…ndler Previous coverage only asserted TokenValidationParameters held the right configured values. These tests actually round-trip a generated token through validation to prove expired/wrong-key/wrong-issuer/wrong-audience tokens are rejected, not just configured to be rejected.
PublishRepositoryUrl/EmbedUntrackedSources only populated cosmetic nuspec metadata; no PDB shipped and no .snupkg was produced. Adds Microsoft.SourceLink.GitHub plus IncludeSymbols/SymbolPackageFormat=snupkg. Verified: packed PDBs now embed a SourceLink URL pointing at the exact commit.
Tags existed with packages published to NuGet.org, but the GitHub Releases page was empty. Adds a step using gh release create --generate-notes (auto-summarizes merged PRs/commits since the previous tag) with the packed .nupkg/.snupkg attached as assets. Applies going forward only; existing tags are not backfilled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.