Fix/templates pack symbols and fluent validation filter - #21
Merged
Duon0402 merged 2 commits intoAug 18, 2026
Merged
Conversation
added 2 commits
August 18, 2026 10:28
Directory.Build.props' global IncludeSymbols=true/SymbolPackageFormat=snupkg tried to produce a .snupkg for DuonDevKit.Templates too, but it has no compiled output (IncludeBuildOutput=false, content-only package) — an empty symbols package fails dotnet pack with NU5017 even though the main .nupkg packs fine, silently blocking the entire publish job (confirmed: this is why tag v0.12.0's publish run failed at the Pack DuonDevKit.Templates step, before ever reaching NuGet push or GitHub Release). Overrides IncludeSymbols back to false for this project only. Reproduced and verified fixed using the exact 'dotnet build --no-restore && dotnet pack --no-build' sequence publish.yml runs.
…erpart to ValidationFilter<T> Resolves an IValidator<T> from DI and produces the exact same 400 field-level ValidationProblem shape as the DataAnnotations filter, so both validation styles are interchangeable at the Minimal API boundary (Option B from the earlier validation-shape discussion). Trade-off accepted deliberately: DuonDevKit.AspNetCore now references DuonDevKit.Validation (and transitively FluentValidation) unconditionally, so every AspNetCore consumer gets that dependency even when only using DataAnnotations — confirmed via a local NuGet feed that even the template's default (no --validation) scaffold now carries FluentValidation transitively; it still builds clean, just with a heavier dependency footprint. Bumps DuonDevKit.AspNetCore 0.4.1 -> 0.5.0 (minor: additive API + dependency footprint change) and updates the template's pinned reference to match.
Duon0402
deleted the
fix/templates-pack-symbols-and-fluent-validation-filter
branch
August 18, 2026 03:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.