docs(cli): remove duplicate dc.gate section on observer - #10
Merged
Elektr0Vodka merged 3 commits intoSep 26, 2026
Merged
Conversation
`set dc.gate` parsed its value with atoi(), so `set dc.gate on` evaluated to 0 and silently disabled region gating while replying OK. It now accepts on/off as well as 1/0 and rejects anything else with an error. Docs (cli_commands.md): dc.gate.thresh, dc.gate.hyst and the duty in `get dc.gate.status` are a percentage of the duty-cycle budget, not of wall-clock time. Worked example for dutycycle 10. Also removes the duplicated "Duty-cycle region gating" chapter left by an earlier merge, keeping the observer-only region_gate MQTT notes in the remaining copy. (cherry picked from commit b12c3fa)
…ver-dev-dc-gate-on-off docs/cli_commands.md: keep this branch's single deduped dc.gate section (dmc-dev's PR #9 wording arrived via the observer merge and re-added the duplicate); carry over the upstream doc updates from the sync (radio/freq defaults, direct.txdelay, agc.reset.interval 0-1020, flood.advert.interval, advert.interval zero-hop note).
Elektr0Vodka
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observer counterpart of #9 — now docs-only.
Update 2026-09-26
The code half of this PR (
set dc.gateacceptingon/off) reacheddmc-observer-devthrough the upstream sync, which mergeddmc-dev(including #9) into the observer. That made this PR conflict. The branch now has the currentdmc-observer-devmerged in, and what remains is the docs dedupe below.Change
docs/cli_commands.md: the "Duty-cycle region gating" chapter appears twice ondmc-observer-dev(a merge leftover). This removes the stale copy (−65 lines), which still described the threshold as a % of wall-clock TX time andset dc.gate <0|1>. The remaining copy has #9's wording (on/off, "% of the duty-cycle budget", the "What the percentage measures" section) and keeps the observer-onlyregion_gateMQTT note.The merge also keeps the sync's other doc updates (radio/freq defaults,
direct.txdelay,agc.reset.interval0-1020, advert interval defaults).Testing
dmc-observer-devisdocs/cli_commands.mdonly (0 insertions, 65 deletions); no source changes.region_gateMQTT block).🤖 Generated with Claude Code