feat(web-standalone): show the loading overlay while a region's proven links are pulled - #122
Merged
Merged
Conversation
…n links are pulled Choosing a region pulls proven links for up to 14 nodes, 5 to 15 seconds, and the only sign was a status line in Step 1, off-screen on a phone since #118 scrolls to Step 2 (#121). A shared link already had the right pattern: a loading overlay with a spinner, a title and one line on what is being waited for. The shared-link splash is now the app's loading overlay: #loading-overlay with showLoading(title, sub) and hideLoading(token). The token ties each hide to its own show, so a stale activation finishing late cannot take down a newer one's overlay. The card click and switchToRegion() show "Pulling proven links for region N…" and hide it in the promise's finally, so a failed pull clears it too. The shared-link flow uses the same calls with its old text. Verified in the pane at 412 px: overlay hidden after discovery, shown with the region text 300 ms after tapping a card, hidden once the cluster is locked; shown by hand it is fixed, full-viewport, z 5000, display flex. The pane's screenshots do not composite fixed overlays, so the check is on the DOM and computed style. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #121.
Choosing a region pulls proven links for up to 14 nodes, 5 to 15 seconds, and the only sign was a status line in Step 1, off-screen on a phone since #118 scrolls to Step 2. A shared link already had the right pattern: a loading overlay with a spinner, a title and one line on what is being waited for.
Change
#loading-overlaywithshowLoading(title, sub)andhideLoading(token). The token ties each hide to its own show, so a stale activation finishing late cannot take down a newer one's overlay.finally, so a failed pull clears it too.loading-card,loading-sub,loading-spinner).Verified
In the pane at 412 px, on the DOM and computed style (the pane's screenshots do not composite fixed overlays): hidden after discovery, shown with the region text 300 ms after tapping a card, hidden once the cluster is locked; shown by hand it is
position: fixed, full viewport, z-index 5000,display: flex.🤖 Generated with Claude Code